Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STATIC_URL and MEDIA_URL are now customizable #830

Closed
wants to merge 2 commits into from
Closed

Conversation

xhub
Copy link

@xhub xhub commented Dec 4, 2019

this url customization is taken from pretix. This allow for a customization of the static and media urls. This is handy when using a reverse proxy from the same vhost for multiple Django app.

How Has This Been Tested?

Tested on a personal instance. The css for the event has to be regenerated by performing some change in the settings.

Screenshots (if appropriate):

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change is listed in the CHANGELOG.rst if appropriate.

Copy link
Member

@rixx rixx left a comment

Huh, I would never recommend a setup like the one this would enable (high chances of other conflicting URLs spring to mind, after all!), but I agree that it would be nice to have this capability! Thank you very much for providing a PR!

Could you please also add these configuration settings to the documentation, so that others will be able to find and use this setting, too?

Also, it seems that a test related to the schedule HTML export is failing, which puts its data into the media directory – could you look into the failing test, please?

@rixx rixx force-pushed the master branch 2 times, most recently from 6e0cfb6 to a820c7e Compare Dec 21, 2019
@rixx
Copy link
Member

@rixx rixx commented Mar 27, 2020

Closing due to inactivity.

@rixx rixx closed this Mar 27, 2020
rixx added a commit that referenced this issue Mar 27, 2020
Thanks to @xhub for the initial work in #830.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants