Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate django-scopes #1319

Merged
merged 8 commits into from Jun 17, 2019

Conversation

@raphaelm
Copy link
Member

commented Jun 13, 2019

  • Make sure it starts
  • Make sure it runs
  • Adjust all tests
    • api
    • base
    • control
    • presale
    • plugins
    • multidomain
    • helpers
  • Adjust all incoming webhooks
  • Adjust all celery tasks
  • Adjust all management commands
  • Adjust all periodic tasks
  • Adjust all plugins. At least the following need changes:
    • shipping
    • pretix-c3
    • stretchgoals
    • tracking
    • slack
    • shipping
    • saferpay
    • posbackend
    • offliensales
    • mailchimp
    • gdpr
    • accountingtools
    • boabee
    • bounces
    • mollie

@raphaelm raphaelm changed the title Install django-scopes Integrate django-scopes Jun 13, 2019

@raphaelm raphaelm changed the title Integrate django-scopes [WIP] Integrate django-scopes Jun 13, 2019

@raphaelm raphaelm force-pushed the scopes branch from 77ef872 to 75c04c7 Jun 13, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 13, 2019

Codecov Report

Merging #1319 into master will increase coverage by 0.06%.
The diff coverage is 86.77%.

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   80.55%   80.62%   +0.06%     
==========================================
  Files         273      274       +1     
  Lines       29001    29188     +187     
==========================================
+ Hits        23361    23532     +171     
- Misses       5640     5656      +16
Impacted Files Coverage Δ
src/pretix/control/forms/orders.py 91.87% <ø> (ø) ⬆️
src/pretix/plugins/badges/views.py 72.25% <ø> (ø) ⬆️
...pretix/presale/management/commands/updatestyles.py 0% <0%> (ø) ⬆️
src/pretix/base/models/checkin.py 92.85% <100%> (+0.54%) ⬆️
src/pretix/api/views/voucher.py 96.55% <100%> (+0.08%) ⬆️
src/pretix/control/forms/vouchers.py 95.55% <100%> (+0.03%) ⬆️
src/pretix/base/services/tickets.py 55.64% <100%> (+0.36%) ⬆️
src/pretix/base/services/export.py 50% <100%> (+1.85%) ⬆️
src/pretix/api/auth/device.py 95% <100%> (+0.55%) ⬆️
src/pretix/base/models/orders.py 91.73% <100%> (+0.1%) ⬆️
... and 51 more
@codecov

This comment has been minimized.

Copy link

commented Jun 13, 2019

Codecov Report

Merging #1319 into master will increase coverage by 0.07%.
The diff coverage is 86.84%.

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   80.55%   80.63%   +0.07%     
==========================================
  Files         273      274       +1     
  Lines       29012    29201     +189     
==========================================
+ Hits        23372    23545     +173     
- Misses       5640     5656      +16
Impacted Files Coverage Δ
src/pretix/control/forms/orders.py 91.87% <ø> (ø) ⬆️
src/pretix/plugins/badges/views.py 72.25% <ø> (ø) ⬆️
...pretix/presale/management/commands/updatestyles.py 0% <0%> (ø) ⬆️
src/pretix/base/models/checkin.py 92.85% <100%> (+0.54%) ⬆️
src/pretix/api/views/voucher.py 96.55% <100%> (+0.08%) ⬆️
src/pretix/control/forms/vouchers.py 95.55% <100%> (+0.03%) ⬆️
src/pretix/base/services/tickets.py 55.64% <100%> (+0.36%) ⬆️
src/pretix/base/services/export.py 50% <100%> (+1.85%) ⬆️
src/pretix/api/auth/device.py 95% <100%> (+0.55%) ⬆️
src/pretix/base/models/orders.py 91.78% <100%> (+0.1%) ⬆️
... and 52 more

@raphaelm raphaelm force-pushed the scopes branch from c0b1d16 to 8027337 Jun 14, 2019

@raphaelm raphaelm changed the title [WIP] Integrate django-scopes Integrate django-scopes Jun 17, 2019

@raphaelm raphaelm force-pushed the scopes branch from 8027337 to b41139a Jun 17, 2019

@raphaelm raphaelm merged commit d85ddb5 into master Jun 17, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.