Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prettier should only be peer and dev dependence #37

Merged
merged 1 commit into from Nov 10, 2019

Conversation

@JounQin
Copy link
Contributor

JounQin commented Nov 10, 2019

No description provided.

@Shinigami92 Shinigami92 self-requested a review Nov 10, 2019
Copy link
Member

Shinigami92 left a comment

Thank you for being the first to contribute to my project

Could you please make the following changes?

  1. Swap prettier with jest in devDependencies
    The order in dependencies should be in alphabetical order
  2. git add package.json
  3. git commit --amend -m "Move prettier to devDependencies"
    This generates a message that better matches all previous commit messages
  4. git push --force
    This leaves only one commit in this PR

使用谷歌翻译

感谢您成为第一个为我的项目做出贡献的人

您能否进行以下更改?

  1. devDependencies中用jest交换prettier
        依存关系的顺序应按字母顺序
  2. git add package.json
  3. git commit --amend -m "Move prettier to devDependencies"
         这将生成一条消息,该消息与以前的所有提交消息都更好地匹配
  4. git push --force
        这在此PR中仅保留一次提交
@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 10, 2019

@Shinigami92 Done. You don't need to translate the texts. 🤣


Besides, I'd like to recommend you to use commitlint which recommends prefix a meaningful type for commit messages.

@Shinigami92 Shinigami92 self-requested a review Nov 10, 2019
@Shinigami92 Shinigami92 merged commit e074715 into prettier:master Nov 10, 2019
1 check passed
1 check passed
prettier.plugin-pug Build #20191110.2 succeeded
Details
@JounQin JounQin deleted the JounQin:patch-1 branch Nov 10, 2019
@Shinigami92

This comment has been minimized.

Copy link
Member

Shinigami92 commented Nov 10, 2019

Besides, I'd like to recommend you to use commitlint which recommends prefix a meaningful type for commit messages.

I know commitlint a bit through other projects, but I do not like it that much for personal reasons because it blocks commit and push via VSCode GUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.