Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should `prettier` be `peer` dependence instead of `dependencies` directly? #431

Closed
JounQin opened this issue Nov 10, 2019 · 1 comment
Closed

Comments

@JounQin
Copy link

@JounQin JounQin commented Nov 10, 2019

As title.

@kddeisz

This comment has been minimized.

Copy link
Member

@kddeisz kddeisz commented Nov 11, 2019

I'd prefer to not do that. It would mean that in projects where people choose to install through npm and they don't have other dependencies it would break for unclear reasons. I'd prefer to provide it by default for that reason. I'd be fine relaxing the dependency restriction on it though, it does look a little tight.

@kddeisz kddeisz closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.