Prettier is removing the doctype from handlebar files #11223

paulsmithkc · 2021-07-18T02:53:33Z

Environments:

Prettier Version: 2.3.2
Running Prettier via: vscode extension
Runtime: Node.js v14.16.0
Operating System: Windows
Prettier plugins (if any): none

Steps to reproduce:

Original code:

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <meta http-equiv="X-UA-Compatible" content="IE=edge">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Document</title>
</head>
<body>
  
</body>
</html>

Formatted code:

<html lang='en'>
  <head>
    <meta charset='UTF-8' />
    <meta http-equiv='X-UA-Compatible' content='IE=edge' />
    <meta name='viewport' content='width=device-width, initial-scale=1.0' />
    <title>Document</title>
  </head>
  <body>

  </body>
</html>

Expected behavior:

The <!DOCTYPE html> should be preserved unchanged.

Actual behavior:

The <!DOCTYPE html> is removed.

The text was updated successfully, but these errors were encountered:

sosukesuzuki · 2021-07-18T17:01:23Z

I cannot reproduce this in playground. Can you reproduce in playground?

Prettier 2.3.2
Playground link

--parser html

Input:

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <meta http-equiv="X-UA-Compatible" content="IE=edge">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Document</title>
</head>
<body>
  
</body>
</html>

Output:

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Document</title>
  </head>
  <body></body>
</html>

no-response · 2021-08-01T17:43:26Z

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

paulsmithkc · 2021-08-04T03:43:05Z

Sorry. This happened when formatting a .handlebars file. The file was located at /views/layouts/main.handlebars.

On further testing, it seems to be a problem .handlebars files, and not .html files. Still a critical bug.

fisker · 2021-08-04T03:56:17Z

Thanks!

Prettier 2.3.2
Playground link

--parser glimmer

Input:

<!DOCTYPE html>
<html lang="en">
</html>

Output:

<html lang="en">
</html>

It seems a known issue in parser. glimmerjs/glimmer-vm#870

…from commit hook There is a huge bug with the `glimmer` library (which prettier relies on for parsing) where the <!DOCTYPE html> tag will get dropped improperly when formatting. I'm replacing the tags and keeping the formatted files here but removing the auto-format settings from commit hooks. See more: prettier/prettier#11223

* chore(package): update husky@7 * chore(actions): optimize update-translations install * chore(package): bump commitlint@13.1.0 * chore: remove extraneous npm messages * chore(package): update lint-staged@11.1.2 * chore(package): bump prettier@2.3.2 * chore(templates): clean up with prettier * chore(package): bump stylelint deps * fix(view): plausible domain var * fix(prettier): keep formatted hbs for now, but remove hbs formatting from commit hook There is a huge bug with the `glimmer` library (which prettier relies on for parsing) where the <!DOCTYPE html> tag will get dropped improperly when formatting. I'm replacing the tags and keeping the formatted files here but removing the auto-format settings from commit hooks. See more: prettier/prettier#11223

Officialstrike · 2022-02-04T06:34:41Z

Seems still to be an issue after the official release of handlebars support and glimmerjs fixing the issue?

mwyschan · 2022-07-03T15:15:12Z

According to glimmerjs/glimmer-vm#870, the issues have already been fixed in glimmerjs/glimmer-vm#1305. However, I'm experiencing the same issues with v2.7.1.

Chikanka · 2022-08-08T12:29:14Z

I found this issue on https://ovio.org/projects and would love to contribute!

fisker · 2022-08-08T13:46:30Z

Go ahead!

fisker · 2022-09-08T11:39:21Z

I tried to work on this, but it seems the doctype info still missing in AST.

> require('@glimmer/syntax').preprocess('<!DOCTYPE html>')
{
  type: 'Template',
  body: [],
  blockParams: [],
  loc: SourceSpan {
    data: HbsSpan {
      source: [Source],
      hbsPositions: [Object],
      kind: 'HbsPosition',
      _charPosSpan: null,
      _providedHbsLoc: [Object]
    },
    isInvisible: false
  }
}

portfolioris · 2023-04-14T06:19:11Z

This happens to .astro files too.

However, due to prettier/prettier#11223, we don't always run Prettier on the handlebars file. Only manually and we add back `<!DOCTYPE html>` to the template.

RohithCIS · 2023-07-03T21:16:20Z

On, VS Code the following .prettierrc works

{
  "overrides": [
    {
      "files": "*.handlebars",
      "options": {
        "parser": "html"
      }
    }
  ]
}

Andrew15-5 · 2023-07-05T21:49:54Z

On, VS Code the following .prettierrc works

Prettier does not depend on text editor.

I tested it on prettier v2.8.8 and it works. Thanks.

Here's my config in .prettierrc.toml:

overrides = [
  { files = "*.hbs", options = { parser = "html" } }
]

sosukesuzuki added lang:html Issues affecting HTML (and SVG but not JSX) status:awaiting response Issues that require answers to questions from maintainers before action can be taken labels Jul 18, 2021

no-response bot closed this as completed Aug 1, 2021

no-response bot removed the status:awaiting response Issues that require answers to questions from maintainers before action can be taken label Aug 4, 2021

no-response bot reopened this Aug 4, 2021

fisker mentioned this issue Aug 3, 2022

why doctype is removed #13214

Closed

jonassterud mentioned this issue Dec 2, 2022

Prettier is removing <!DOCTYPE html> for .hbs files jonassterud/travelto#5

Closed

paulsmithkc changed the title ~~Prettier is removing the doctype from HTML files~~ Prettier is removing the doctype from handebar files Dec 16, 2022

paulsmithkc changed the title ~~Prettier is removing the doctype from handebar files~~ Prettier is removing the doctype from handlebar files Dec 16, 2022

Eric-Arellano mentioned this issue May 11, 2023

Autoformat city_detail with Prettier ParkingReformNetwork/reform-map#117

Merged

fisker mentioned this issue Aug 7, 2023

<!doctype> removed in Handlebars #15220

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prettier is removing the doctype from handlebar files #11223

Prettier is removing the doctype from handlebar files #11223

paulsmithkc commented Jul 18, 2021 •

edited

sosukesuzuki commented Jul 18, 2021

no-response bot commented Aug 1, 2021

paulsmithkc commented Aug 4, 2021

fisker commented Aug 4, 2021

Officialstrike commented Feb 4, 2022

mwyschan commented Jul 3, 2022 •

edited

Chikanka commented Aug 8, 2022

fisker commented Aug 8, 2022

fisker commented Sep 8, 2022 •

edited

portfolioris commented Apr 14, 2023

RohithCIS commented Jul 3, 2023 •

edited

Andrew15-5 commented Jul 5, 2023

Prettier is removing the doctype from handlebar files #11223

Prettier is removing the doctype from handlebar files #11223

Comments

paulsmithkc commented Jul 18, 2021 • edited

sosukesuzuki commented Jul 18, 2021

no-response bot commented Aug 1, 2021

paulsmithkc commented Aug 4, 2021

fisker commented Aug 4, 2021

Officialstrike commented Feb 4, 2022

mwyschan commented Jul 3, 2022 • edited

Chikanka commented Aug 8, 2022

fisker commented Aug 8, 2022

fisker commented Sep 8, 2022 • edited

portfolioris commented Apr 14, 2023

RohithCIS commented Jul 3, 2023 • edited

Andrew15-5 commented Jul 5, 2023

paulsmithkc commented Jul 18, 2021 •

edited

mwyschan commented Jul 3, 2022 •

edited

fisker commented Sep 8, 2022 •

edited

RohithCIS commented Jul 3, 2023 •

edited