Add parentheses for TSTypeQuery in some case

[fisker]

Prettier 2.7.1
Playground link

--parser typescript

Input:

a as (typeof node.children)[number]

a as (typeof node.children)[]

a as ((typeof node.children)[number])[]

Output:

a as typeof node.children[number];

a as typeof node.children[];

a as typeof node.children[number][];

Expected behavior:

Same as input

[thorn0]

a as ((typeof node.children)[number])[]

This one is too many parens. It looks fine and unambiguous without the outer ones:

a as (typeof node.children)[number][]

Otherwise, I don't think any discussion is needed here. It's a regression in 1.19.

[fabioStori]

@thorn0 the goal is to make the input
a as ((typeof node.children)[number])[]
result in
a as (typeof node.children)[number][]
right?

[fisker]

Yes, a as (typeof node.children)[number][] is expected.

[fabioStori]

@fisker Thank you for the confirmation.
Just to better understand the motivation, can you explain the reasoning behind the logic of maintaining the parentheses around the typeof node.children in the scenario a as ((typeof node.children)[number])[] , but removing it in the a as (typeof node.children)[number] scenario?
I understand that, in this first example, the outer parentheses can make the code look ambiguous, but in this second one the reason is still not clear to me.

I have another question, based on a scenario I encountered while working on this.
If the input is something like a as typeof node.children[number][];, should the parentheses be added, resulting in a as (typeof node.children)[number][];?

[fisker]

can you explain the reasoning

#13546 (comment)

If the input is something like a as typeof node.children[number][];

Yes.

[fisker]

Fixed by #14042

[zomars]

Do we have an option to disable this?

[mikedidomizio]

If the purpose of this was for readability, should we have it as optional?

[demc]

Please either make this rule optional or revert. Thank you