Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Deprecates @types/prettier and maintains type definitions in prettier/prettier repository #14033

Closed
sosukesuzuki opened this issue Dec 18, 2022 · 2 comments
Labels
area:api Issues with Prettier's Application Programming Interface locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself

Comments

@sosukesuzuki
Copy link
Member

sosukesuzuki commented Dec 18, 2022

Background

Proposal

  1. Moves @types/prettier to https://github.com/prettier/prettier.
  2. Deprecates @types/prettier.

Pros

  • Definitely Typed is a huge repository, so it is slightly hard to fix for us.
  • Easy to synchronize type definitions with Prettier's API implementation.
  • API users do not need to install @types/prettier, need only prettier.
  • Some plugins are implemented in TypeScript, so improving their development experience makes a lot of sense.

Cons

  • Increase the maintenance cost.
  • Increase the npm package size.

References

@sosukesuzuki sosukesuzuki added type:meta Issues about the status of Prettier, or anything else about Prettier itself area:api Issues with Prettier's Application Programming Interface labels Dec 18, 2022
@carmanchris31
Copy link

Thank you very much for opening this!

@fisker
Copy link
Member

fisker commented Feb 24, 2023

Fixed by #14212

@fisker fisker closed this as completed Feb 24, 2023
@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:api Issues with Prettier's Application Programming Interface locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself
Projects
None yet
Development

No branches or pull requests

3 participants