Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] remove option `vueIndentScriptAndStyle` or rename it to treat all html style files consistently #7000

Closed
JounQin opened this issue Nov 18, 2019 · 2 comments

Comments

@JounQin
Copy link
Contributor

@JounQin JounQin commented Nov 18, 2019

First of all, we have https://prettier.io/docs/en/option-philosophy.html

Secondly,

Besides, I even don't like option vueIndentScriptAndStyle personally, why it's related to vue only? Svelte has .html/.svelte as SFC also. We should treat them as html without distinction, and we should have only one style for html like files: indented or non-indented everywhere. Why should we care about that. Just accept the default formats, you will be happy all the time someday.

No more options please until it breaks your codes like #5588 or #6626.

See my comments at #3903 (comment)

.vue is should not be treated specially.

My personal idea approach:

  1. Remove the option, treat .vue not specially, indented or non-indented everywhere even for head and body tag
  2. Rename the option to affect all html like files

Besides, shall we have a separate repository for RFCs?

@lydell

This comment has been minimized.

Copy link
Collaborator

@lydell lydell commented Nov 19, 2019

Hi!

Unfortunately, you’re too late to the game. This has already been discussed to death in #3888, where even the creator of Vue pitched in. I don’t want the option either, but now we have it.

We also explored having it general for all HTML like files, but it didn’t work out. Read through #3888 and the PRs that link to it for the full history.

@lydell lydell closed this Nov 19, 2019
@JounQin

This comment has been minimized.

Copy link
Contributor Author

@JounQin JounQin commented Nov 19, 2019

@lydell

Now we will have 2.0 to include BREAKING CHANGES, don't we? And the Vue author should not take higher priority IMO. So I recommend to retalk about it again. Of course, I'm free to be rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.