Repository navigation
Testing with source code from other repositories #9290
Description
We run the latest Prettier on the other repositories' source code to check for regressions before we release.
like below:
- Use prettier next (2.1) sosukesuzuki/eslint-plugin-vue#1
- Use prettier next (2.1) sosukesuzuki/excalidraw#2
- Use prettier next (2.1) sosukesuzuki/typescript-eslint#1
This is hard to do manually, so I want to automate it.
Activity
fisker commentedon Sep 29, 2020
Use a separate repo,
prettier/prettierand other repositories as submodule.sosukesuzuki commentedon Sep 29, 2020
What do you think about adding to this repository as a integration test and checking with a CI for each PR?
fisker commentedon Sep 29, 2020
Will this test fail, if format changed? Or are you thinking about snapshot the result?
sosukesuzuki commentedon Sep 29, 2020
Sorry, I was mistaken. I'll try with your suggestion.
sosukesuzuki commentedon Oct 1, 2020
I created a repository https://github.com/sosukesuzuki/prettier-regression-testing.
I don't know the way to see diffs of submodules on PR. So, I implemented an action using issue comments for checking diffs. See example issue: sosukesuzuki/prettier-regression-testing#4.
This has only
typescript-eslintas a submodule because work in progress.fisker commentedon Oct 1, 2020
Maybe no submodule,
git clone->git commit->run format->git commit?sosukesuzuki commentedon Oct 1, 2020
Hmm, we want to see just diffs. So I think submodule and issue comments is enough. They are also relatively easy to manage.
fisker commentedon Oct 1, 2020
I don't know how to see submodule diff either.
We can check the second commit to see diff.
sosukesuzuki commentedon Oct 1, 2020
sosukesuzuki/prettier-regression-testing#4 (comment)
I'll use it to check regressions in the next release. If we are unhappy with it, you can improve it afterwards.
I close this issue for now.