Fix import declaration comments #1030

Merged
merged 5 commits into from Mar 17, 2017

Conversation

Projects
None yet
2 participants
@yamafaktory
Contributor

yamafaktory commented Mar 16, 2017

This one should fix #1011.

yamafaktory added some commits Mar 16, 2017

tests/import/comments.js
@@ -20,3 +20,12 @@ import {
a as //comment3 //comment2 //comment1
b
} from "";
+
+import {
+ FN1,

This comment has been minimized.

@vjeux

vjeux Mar 17, 2017

Collaborator

In the examples, can you add all the comment types: before same line, after same line, before own line, after own line?

I have a feeling that it's not going to work properly with this implementation

@vjeux

vjeux Mar 17, 2017

Collaborator

In the examples, can you add all the comment types: before same line, after same line, before own line, after own line?

I have a feeling that it's not going to work properly with this implementation

yamafaktory added some commits Mar 17, 2017

@yamafaktory

This comment has been minimized.

Show comment
Hide comment
@yamafaktory

yamafaktory Mar 17, 2017

Contributor

@vjeux I've changed the implementation and made the test more exhaustive.

Contributor

yamafaktory commented Mar 17, 2017

@vjeux I've changed the implementation and made the test more exhaustive.

@vjeux vjeux merged commit 748dcbf into prettier:master Mar 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yamafaktory yamafaktory deleted the yamafaktory:1011-fix-import-declaration-comments branch Mar 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment