Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make options argument in parsers optional #11892

Merged
merged 2 commits into from Dec 2, 2021

Conversation

fisker
Copy link
Member

@fisker fisker commented Dec 1, 2021

Description

Fixes #11888

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fisker fisker merged commit 16b6825 into prettier:main Dec 2, 2021
25 checks passed
@fisker fisker deleted the options-optional branch Dec 2, 2021
@sosukesuzuki
Copy link
Member

sosukesuzuki commented Dec 2, 2021

@fisker Sorry after merged, it is good to have changelog for this change.

@fisker
Copy link
Member Author

fisker commented Dec 2, 2021

I think we should not encourage people use the parsers directly, but make sense to add changelog says we fixed the jest issue, is it fine?

@sosukesuzuki
Copy link
Member

sosukesuzuki commented Dec 2, 2021

Yes, It would be better for users to know that this fixes the problem with jest. (Of course, I don't want a user to use the parser directly...)

fisker added a commit to fisker/prettier that referenced this pull request Dec 2, 2021
sosukesuzuki pushed a commit that referenced this pull request Dec 3, 2021
sosukesuzuki pushed a commit that referenced this pull request Dec 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"TypeError: Cannot set property 'originalText' of undefined" from TypeScript Jest inline snapshot
3 participants