Reduce bundle size of parser-html.js#12176
Merged
fisker merged 2 commits intoprettier:mainfrom Jan 28, 2022
Merged
Conversation
fisker
reviewed
Jan 27, 2022
| const arrayToMap = require("./array-to-map.js"); | ||
|
|
||
| const HTML_ELEMENT_ATTRIBUTES = mapObject(htmlElementAttributes, arrayToMap); | ||
|
|
Member
There was a problem hiding this comment.
Can you try use html-elements-attributes.evaluate.js as filename to see if the bundle became smaller?
Contributor
Author
There was a problem hiding this comment.
I tried it in my local but bundle size didn't became smaller.
Building packages
parser-html.js..................................................156 kB DONE
Member
There was a problem hiding this comment.
Thanks, it's not safe anyway, mapObject use Object.create(null), but turns to JSON will be an normal object
HTML_ELEMENT_ATTRIBUTES.prototype will be truly.
fisker
reviewed
Jan 27, 2022
|
|
||
| const HTML_TAGS = arrayToMap(htmlTagNames); | ||
|
|
||
| module.exports = HTML_TAGS; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before:
After:
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨