Use appropriate chalk instance for stderr output #13098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chalk auto-detects whether the output channel supports colors, but does that for stderr. Consequently, colors appear inconsistently (and wrongly) depending on whether stdout or stderr have been redirected.
Issue: #13097
Description
This change corrects the instance of chalk used, according to the employed output channel (stdout or stderr).
Checklist
run-pretties.js
(its existingprocess.stdin.isTTY
code is bogus, becausechalk
calls directlyisatty()
),chalk
sets the values at the module level), andchalk
object withObject.defineProperty
(it doesn't work, because theconfigurable
is set to false).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨