Use appropriate chalk instance for stderr output#13098
Merged
sosukesuzuki merged 1 commit intoprettier:mainfrom Jul 13, 2022
dspinellis:issue-13097-stderr-colors
Merged
Use appropriate chalk instance for stderr output#13098sosukesuzuki merged 1 commit intoprettier:mainfrom dspinellis:issue-13097-stderr-colors
sosukesuzuki merged 1 commit intoprettier:mainfrom
dspinellis:issue-13097-stderr-colors
Conversation
Chalk auto-detects whether the output channel supports colors, but does that for stderr. Consequently, colors appear inconsistently (and wrongly) depending on whether stdout or stderr have been redirected. Issue: #13097
sosukesuzuki
approved these changes
Jul 13, 2022
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Jan 4, 2024
Chalk auto-detects whether the output channel supports colors, but does that for stderr. Consequently, colors appear inconsistently (and wrongly) depending on whether stdout or stderr have been redirected. Issue: prettier#13097
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chalk auto-detects whether the output channel supports colors, but does that for stderr. Consequently, colors appear inconsistently (and wrongly) depending on whether stdout or stderr have been redirected.
Issue: #13097
Description
This change corrects the instance of chalk used, according to the employed output channel (stdout or stderr).
Checklist
run-pretties.js(its existingprocess.stdin.isTTYcode is bogus, becausechalkcalls directlyisatty()),chalksets the values at the module level), andchalkobject withObject.defineProperty(it doesn't work, because theconfigurableis set to false).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨