Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handlebars: Add tests for {{! prettier-ignore}} #13693

merged 2 commits into from Jan 4, 2023


Copy link

@dcyriller dcyriller commented Oct 20, 2022


This PR adds test cases for {{! prettier-ignore}} when it is above or before:

  • a text element
  • a mustache element
  • a block element
  • a comment element

@fisker it should help with #13690


  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/ file following changelog_unreleased/
  • I’ve read the contributing guidelines.

Try the playground for this PR

when the next relevant node is right after the directive
Copy link

fisker commented Oct 20, 2022

Thanks for the test. It seems a little tricky to handle all these cases. Would you like to work on it?
If you do, please target the next branch, code changed in utils.

@fisker fisker changed the title Add tests for {{! prettier-ignore}} Handlebars: Add tests for {{! prettier-ignore}} Jan 4, 2023
@fisker fisker merged commit cf36209 into prettier:main Jan 4, 2023
28 checks passed
@dcyriller dcyriller deleted the add-tests branch January 17, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants