Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Support TS4.9 satisfies operator (#13764)" #13783

Merged
merged 11 commits into from Nov 4, 2022

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Nov 2, 2022

Description

Backports #13381 and #13733
This is a first step of backporting satisfies (#13764 (comment))

Checklist

Try the playground for this PR

@sosukesuzuki sosukesuzuki changed the title Backport #13381 and #13733 Backport TypeScript parsers update Nov 2, 2022
@sosukesuzuki sosukesuzuki marked this pull request as ready for review Nov 3, 2022
@sosukesuzuki sosukesuzuki requested a review from fisker Nov 3, 2022
@sosukesuzuki
Copy link
Member Author

I'll investigate why CI is failing...

@fisker
Copy link
Member

fisker commented Nov 3, 2022

@fisker
Copy link
Member

fisker commented Nov 3, 2022

Because next not rebased?

@sosukesuzuki
Copy link
Member Author

sosukesuzuki commented Nov 3, 2022

Shouldn't this diff be empty?

@fisker Why? Ah I got what do you mean. But I'm not sure why.

@sosukesuzuki

This comment has been hidden.

@fisker fisker mentioned this pull request Nov 3, 2022
4 tasks
@sosukesuzuki sosukesuzuki changed the title Backport TypeScript parsers update Backport satisfies Nov 3, 2022
@ngregory-rbi
Copy link

Hello :) Please merge this in if and when you can :)

@fisker fisker changed the title Backport satisfies Backport "Support TS4.9 satisfies operator (#13764)" Nov 4, 2022
@fisker fisker merged commit ff0529a into prettier:main Nov 4, 2022
32 checks passed
@fisker
Copy link
Member

fisker commented Nov 4, 2022

@sosukesuzuki You changed this line in this PR, right? cccedf4 (#9583)

@sosukesuzuki
Copy link
Member Author

@sosukesuzuki You changed this line in this PR, right? cccedf4 (#9583)

Yes, I forgot to fix this in the original PR.

@sosukesuzuki sosukesuzuki deleted the backport-satisfies-2 branch Nov 4, 2022
@fisker
Copy link
Member

fisker commented Nov 4, 2022

Can you commit this change to next?

@sosukesuzuki
Copy link
Member Author

Yes

@ngregory-rbi
Copy link

thanks for the merge :) just curious though, will this be included in a new mainline release 2.x.x soon?

@sosukesuzuki
Copy link
Member Author

This PR is only supported by the babel-ts parser; to make it also supported by the typescript parser, we need to wait typescript-eslint/typescript-eslint#5716 and typescript-eslint/typescript-eslint#5717 to be merge to typescript-eslint.

@sosukesuzuki sosukesuzuki mentioned this pull request Nov 6, 2022
4 tasks
sosukesuzuki added a commit that referenced this pull request Nov 6, 2022
* Add changelog

* Fix
@kachkaev kachkaev added this to the 2.8 milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants