Support TypeScript 5 #13819
Merged
Support TypeScript 5 #13819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if you saw it in my PR, but https://github.com/jakebailey/prettier-style-ts-tree-shaking is my PoC for getting a similar result for 5.0. |
|
I did. But I'm not going to use rollup. |
|
Oh, I see, you're using esbuild's comments like |
|
Let's remove this prettier/src/language-js/print/class.js Line 307 in 3fc6298 |
|
Changlog missing. |
fisker
commented
Mar 14, 2023
tests/format/typescript/decorator-auto-accessors/__snapshots__/jsfmt.spec.js.snap
Outdated
Show resolved
Hide resolved
This was referenced Mar 15, 2023
fisker
added a commit
that referenced
this pull request
Mar 20, 2023
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 29, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [prettier](https://prettier.io) ([source](https://github.com/prettier/prettier)) | devDependencies | patch | [`2.8.4` -> `2.8.7`](https://renovatebot.com/diffs/npm/prettier/2.8.4/2.8.7) | --- ### Release Notes <details> <summary>prettier/prettier</summary> ### [`v2.8.7`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#​287) [Compare Source](prettier/prettier@2.8.6...2.8.7) [diff](prettier/prettier@2.8.6...2.8.7) ##### Allow multiple decorators on same getter/setter ([#​14584](prettier/prettier#14584) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```ts // Input class A { @​decorator() get foo () {} @​decorator() set foo (value) {} } // Prettier 2.8.6 SyntaxError: Decorators cannot be applied to multiple get/set accessors of the same name. (5:3) 3 | get foo () {} 4 | > 5 | @​decorator() | ^^^^^^^^^^^^ 6 | set foo (value) {} 7 | } // Prettier 2.8.7 class A { @​decorator() get foo() {} @​decorator() set foo(value) {} } ``` ### [`v2.8.6`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#​286) [Compare Source](prettier/prettier@2.8.5...2.8.6) [diff](prettier/prettier@2.8.5...2.8.6) ##### Allow decorators on private members and class expressions ([#​14548](prettier/prettier#14548) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```ts // Input class A { @​decorator() #privateMethod () {} } // Prettier 2.8.5 SyntaxError: Decorators are not valid here. (2:3) 1 | class A { > 2 | @​decorator() | ^^^^^^^^^^^^ 3 | #privateMethod () {} 4 | } // Prettier 2.8.6 class A { @​decorator() #privateMethod() {} } ``` ### [`v2.8.5`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#​285) [Compare Source](prettier/prettier@2.8.4...2.8.5) [diff](prettier/prettier@2.8.4...2.8.5) ##### Support TypeScript 5.0 ([#​14391](prettier/prettier#14391) by [@​fisker](https://github.com/fisker), [#​13819](prettier/prettier#13819) by [@​fisker](https://github.com/fisker), [@​sosukesuzuki](https://github.com/sosukesuzuki)) TypeScript 5.0 introduces two new syntactic features: - `const` modifiers for type parameters - `export type *` declarations ##### Add missing parentheses for decorator ([#​14393](prettier/prettier#14393) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```jsx // Input class Person { @​(myDecoratorArray[0]) greet() {} } // Prettier 2.8.4 class Person { @​myDecoratorArray[0] greet() {} } // Prettier 2.8.5 class Person { @​(myDecoratorArray[0]) greet() {} } ``` ##### Add parentheses for `TypeofTypeAnnotation` to improve readability ([#​14458](prettier/prettier#14458) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```tsx // Input type A = (typeof node.children)[]; // Prettier 2.8.4 type A = typeof node.children[]; // Prettier 2.8.5 type A = (typeof node.children)[]; ``` ##### Support `max_line_length=off` when parsing `.editorconfig` ([#​14516](prettier/prettier#14516) by [@​josephfrazier](https://github.com/josephfrazier)) If an .editorconfig file is in your project and it sets `max_line_length=off` for the file you're formatting, it will be interpreted as a `printWidth` of `Infinity` rather than being ignored (which previously resulted in the default `printWidth` of 80 being applied, if not overridden by Prettier-specific configuration). <!-- prettier-ignore --> ```html <!-- Input --> <div className='HelloWorld' title={`You are visitor number ${ num }`} onMouseOver={onMouseOver}/> <!-- Prettier 2.8.4 --> <div className="HelloWorld" title={`You are visitor number ${num}`} onMouseOver={onMouseOver} />; <!-- Prettier 2.8.5 --> <div className="HelloWorld" title={`You are visitor number ${num}`} onMouseOver={onMouseOver} />; ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMjQuMiJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1832 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
microsoft/TypeScript#51387
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨