TypeScript: Fix issue with double semicolon caused by // prettier-ignore on a call signature line#14830
Merged
fisker merged 3 commits intoprettier:mainfrom May 19, 2023
Merged
Conversation
alexander-akait
approved these changes
May 18, 2023
fisker
reviewed
May 18, 2023
| prop.node.type === "TSMethodSignature" || | ||
| prop.node.type === "TSConstructSignatureDeclaration") && | ||
| prop.node.type === "TSConstructSignatureDeclaration" || | ||
| prop.node.type === "TSCallSignatureDeclaration") && |
Member
There was a problem hiding this comment.
Looks like these types are not like Property(semi belong to them, but comma not belong to Property).
Have to say we are not printing them correctly, but not your fault. We should fix in future.
fisker
approved these changes
May 18, 2023
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 15, 2024
…nore` on a call signature line (prettier#14830)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14786
Fix to not insert a semicolon at the end of a call signature line with prettier-ignore comment.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨