From 773c2efe5be61fdd05ab740b83d572639d5a03ff Mon Sep 17 00:00:00 2001 From: Pietrucci-Blacher Date: Thu, 14 Mar 2024 12:34:17 +0100 Subject: [PATCH 1/6] Fix: Fixed git-format-staged in precommit documentation Cleaned some deprecated stuff --- docs/precommit.md | 12 ++++++------ website/versioned_docs/version-stable/precommit.md | 10 +++++----- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/precommit.md b/docs/precommit.md index 7925c9d7fdd9..9fc59adf04b9 100644 --- a/docs/precommit.md +++ b/docs/precommit.md @@ -72,25 +72,25 @@ Git-format-staged requires Python v3 or v2.7. Python is usually pre-installed on ```bash -npx husky-init +npx husky init npm install --save-dev git-format-staged -npx husky set .husky/pre-commit "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." +echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit ``` ```bash -npx husky-init # add --yarn2 for Yarn 2 +npx husky init # add --yarn2 for Yarn 2 yarn add --dev git-format-staged -yarn husky set .husky/pre-commit "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." +echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit ``` ```bash -pnpm exec husky-init +pnpm exec husky init pnpm add --save-dev git-format-staged -pnpm husky set .husky/pre-commit "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." +echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit ``` diff --git a/website/versioned_docs/version-stable/precommit.md b/website/versioned_docs/version-stable/precommit.md index 8baa51c8cb07..8f868759587e 100644 --- a/website/versioned_docs/version-stable/precommit.md +++ b/website/versioned_docs/version-stable/precommit.md @@ -73,17 +73,17 @@ Git-format-staged requires Python v3 or v2.7. Python is usually pre-installed on ```bash -npx husky-init +npx husky init npm install --save-dev git-format-staged -npx husky set .husky/pre-commit "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." +echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit ``` ```bash -npx husky-init # add --yarn2 for Yarn 2 +npx husky init # add --yarn2 for Yarn 2 yarn add --dev git-format-staged -yarn husky set .husky/pre-commit "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." +echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit ``` @@ -91,7 +91,7 @@ yarn husky set .husky/pre-commit "git-format-staged -f 'prettier --ignore-unknow ```bash pnpm exec husky-init pnpm add --save-dev git-format-staged -pnpm husky set .husky/pre-commit "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." +echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit ``` From 5c2489512e65961be18ff216e5a7ae98c1d7a950 Mon Sep 17 00:00:00 2001 From: Pietrucci-Blacher Date: Wed, 10 Apr 2024 12:20:08 +0200 Subject: [PATCH 2/6] #16152: Fix: Update yarn command --- docs/precommit.md | 2 +- website/versioned_docs/version-stable/precommit.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/precommit.md b/docs/precommit.md index 203e46368ed9..432010e7bc32 100644 --- a/docs/precommit.md +++ b/docs/precommit.md @@ -80,7 +80,7 @@ echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \ ```bash -npx husky init # add --yarn2 for Yarn 2 +yarn husky init yarn add --dev git-format-staged echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit ``` diff --git a/website/versioned_docs/version-stable/precommit.md b/website/versioned_docs/version-stable/precommit.md index 32588a5c9770..836866155c40 100644 --- a/website/versioned_docs/version-stable/precommit.md +++ b/website/versioned_docs/version-stable/precommit.md @@ -81,7 +81,7 @@ echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \ ```bash -npx husky init # add --yarn2 for Yarn 2 +yarn husky init yarn add --dev git-format-staged echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit ``` From 662ead29b689370960f6d6c88ce432ef74f99aac Mon Sep 17 00:00:00 2001 From: Pietrucci-Blacher Date: Thu, 11 Apr 2024 10:02:18 +0200 Subject: [PATCH 3/6] #16152: Fix: Update bunx husky init command in precommit documentation --- docs/precommit.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/precommit.md b/docs/precommit.md index 432010e7bc32..9a67992a9a48 100644 --- a/docs/precommit.md +++ b/docs/precommit.md @@ -96,7 +96,7 @@ echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \ ```bash -bunx husky-init +bunx husky init bun add --dev git-format-staged echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit ``` From ad72bce6bd4c6918c1cb5bcd5505ed5a03918da6 Mon Sep 17 00:00:00 2001 From: Pietrucci-Blacher Date: Thu, 11 Apr 2024 10:04:20 +0200 Subject: [PATCH 4/6] #16152: Fix: Update git-format-staged generation command for precommit section --- docs/precommit.md | 8 ++++---- website/versioned_docs/version-stable/precommit.md | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/precommit.md b/docs/precommit.md index 9a67992a9a48..6348b7afb616 100644 --- a/docs/precommit.md +++ b/docs/precommit.md @@ -74,7 +74,7 @@ Git-format-staged requires Python v3 or v2.7. Python is usually pre-installed on ```bash npx husky init npm install --save-dev git-format-staged -echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" ``` @@ -82,7 +82,7 @@ echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \ ```bash yarn husky init yarn add --dev git-format-staged -echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" ``` @@ -90,7 +90,7 @@ echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \ ```bash pnpm exec husky init pnpm add --save-dev git-format-staged -echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" ``` @@ -98,7 +98,7 @@ echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \ ```bash bunx husky init bun add --dev git-format-staged -echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit +bun --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" ``` diff --git a/website/versioned_docs/version-stable/precommit.md b/website/versioned_docs/version-stable/precommit.md index 836866155c40..905dccdad5e2 100644 --- a/website/versioned_docs/version-stable/precommit.md +++ b/website/versioned_docs/version-stable/precommit.md @@ -75,7 +75,7 @@ Git-format-staged requires Python v3 or v2.7. Python is usually pre-installed on ```bash npx husky init npm install --save-dev git-format-staged -echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" ``` @@ -83,7 +83,7 @@ echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \ ```bash yarn husky init yarn add --dev git-format-staged -echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" ``` @@ -91,7 +91,7 @@ echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \ ```bash pnpm exec husky-init pnpm add --save-dev git-format-staged -echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" ``` @@ -99,7 +99,7 @@ echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \ ```bash bunx husky init bun add --dev git-format-staged -echo "git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"' ." > .husky/pre-commit +bun --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" ``` From e9e20b69dcb9db375e8e3875ea6245c283c435e5 Mon Sep 17 00:00:00 2001 From: Pietrucci-Blacher Date: Tue, 7 May 2024 14:03:10 +0200 Subject: [PATCH 5/6] Fix: Fix antislash escaping --- docs/precommit.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/precommit.md b/docs/precommit.md index 3db2a405cd4b..7820a503d691 100644 --- a/docs/precommit.md +++ b/docs/precommit.md @@ -59,7 +59,7 @@ Git-format-staged requires Python v3 or v2.7. Python is usually pre-installed on ```bash npx husky init npm install --save-dev git-format-staged -node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\' .\n')" ``` @@ -67,7 +67,7 @@ node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'pret ```bash yarn husky init yarn add --dev git-format-staged -node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\' .\n')" ``` @@ -75,7 +75,7 @@ node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'pret ```bash pnpm exec husky init pnpm add --save-dev git-format-staged -node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\' .\n')" ``` @@ -83,7 +83,7 @@ node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'pret ```bash bunx husky init bun add --dev git-format-staged -bun --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" +bun --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\' .\n')" ``` From 7b60273a59d159fc1a99bc4afb89dedab13f8fa2 Mon Sep 17 00:00:00 2001 From: Pietrucci-Blacher Date: Tue, 7 May 2024 14:04:28 +0200 Subject: [PATCH 6/6] Fix: Add missing changes in website/version-stable precommit doc --- website/versioned_docs/version-stable/precommit.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/website/versioned_docs/version-stable/precommit.md b/website/versioned_docs/version-stable/precommit.md index 905dccdad5e2..63f78a0e45a9 100644 --- a/website/versioned_docs/version-stable/precommit.md +++ b/website/versioned_docs/version-stable/precommit.md @@ -75,7 +75,7 @@ Git-format-staged requires Python v3 or v2.7. Python is usually pre-installed on ```bash npx husky init npm install --save-dev git-format-staged -node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\' .\n')" ``` @@ -83,7 +83,7 @@ node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'pret ```bash yarn husky init yarn add --dev git-format-staged -node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\' .\n')" ``` @@ -91,7 +91,7 @@ node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'pret ```bash pnpm exec husky-init pnpm add --save-dev git-format-staged -node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" +node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\' .\n')" ``` @@ -99,7 +99,7 @@ node --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'pret ```bash bunx husky init bun add --dev git-format-staged -bun --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \\'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\\' .\\n')" +bun --eval "fs.writeFileSync('.husky/pre-commit', 'git-format-staged -f \'prettier --ignore-unknown --stdin --stdin-filepath \"{}\"\' .\n')" ```