Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore node_modules when running prettier from CLI #1683

Merged
merged 7 commits into from May 23, 2017

Conversation

Projects
None yet
2 participants
@thymikee
Copy link
Contributor

thymikee commented May 23, 2017

Summary
Inspired by this comment: #1048 (comment) I thought it may be a good idea to omit node_modules by default when running prettier through CLI. Kinda fixes #1358.

Notable changes:

  • adds new --with-node-modules CLI flag to opt-out from default behavior
  • adds integration tests inside tests_integration directory.
  • adds new npm script command to run integration tests: test-integration

Test plan
Added an integration test suite.

@vjeux

This comment has been minimized.

Copy link
Collaborator

vjeux commented May 23, 2017

Thanks, that's going to save a ton of headache to people!

thymikee added some commits May 23, 2017

@vjeux

This comment has been minimized.

Copy link
Collaborator

vjeux commented May 23, 2017

(I'll merge it when it's green)

@thymikee

This comment has been minimized.

Copy link
Contributor Author

thymikee commented May 23, 2017

Cool. I'm just trying to figure out why it's failing on CI and works on my machine 😅

@vjeux

This comment has been minimized.

Copy link
Collaborator

vjeux commented May 23, 2017

(Feel free to drop the test altogether if you can't make it work :))

@thymikee thymikee force-pushed the thymikee:ignore-node-modules branch from 03962ed to c285d08 May 23, 2017

@thymikee

This comment has been minimized.

Copy link
Contributor Author

thymikee commented May 23, 2017

No wonder it failed, my nested node_module was ignored by git. Took me too long to realize ^^

@thymikee

This comment has been minimized.

Copy link
Contributor Author

thymikee commented May 23, 2017

💚 All green
Feels good

@vjeux vjeux merged commit 7a0df95 into prettier:master May 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thymikee thymikee deleted the thymikee:ignore-node-modules branch May 23, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.