Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation of a do-while condition #2359

Merged
merged 1 commit into from Jun 29, 2017

Conversation

Projects
None yet
3 participants
@jsnajdr
Copy link
Contributor

commented Jun 29, 2017

Fixes #2353. Use the same printing code for both WhileStatement and DoWhileStatement. Fix calculation of isInsideParenthesis when printing a LogicalExpression. There is no such thing as DoStatement -- it should be DoWhileStatement.

Fix indentation of a do-while condition
Fixes #2353. Use the same printing code for both `WhileStatement` and `DoWhileStatement`.
Fix calculation of `isInsideParenthesis` when printing a `LogicalExpression`. There is
no such thing as `DoStatement` -- it should be `DoWhileStatement`.
@hawkrives

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2017

Is the "do expression" proposal called DoExpression then? (Disclaimer: I have no idea if doexprs are listed elsewhere and I've never looked at the prettier source.)

@jsnajdr

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2017

I didn't know that DoExpression exists until now but yes, that's how its AST node type is called. And prettier supports them.

@vjeux

This comment has been minimized.

Copy link
Collaborator

commented Jun 29, 2017

Oops fail, thanks for the fix!

@vjeux vjeux merged commit 3f6a232 into prettier:master Jun 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.