Break closing paren of ConditionalExpression in member chains#2786
Merged
suchipi merged 4 commits intoprettier:masterfrom Sep 10, 2017
Merged
Break closing paren of ConditionalExpression in member chains#2786suchipi merged 4 commits intoprettier:masterfrom
suchipi merged 4 commits intoprettier:masterfrom
Conversation
suchipi
reviewed
Sep 10, 2017
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| (valid | ||
| ? helper.responseBody(this.currentUser) | ||
| : helper.responseBody(this.defaultUser)).prop; |
Member
There was a problem hiding this comment.
I understand why it's happening, but this kinda feels like a regression on the changes in #2784. I think I'm okay with it, though.
Collaborator
Author
There was a problem hiding this comment.
Actually, that's my mistake I forgot to update this test 😳
2d4fbd9 to
2ce3c0a
Compare
Collaborator
Author
|
@suchipi I forgot to update a snapshot 😅 I updated it with what I think would work for logical expressions |
Member
|
Looks like CI is failing due to a format violation; could you fix? |
Collaborator
Author
|
Oops so sorry about that. Fixed! |
This was referenced Feb 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still related to #2775, maybe a better way to print this case.
If you guys think this is cool, let me know if I should do the same for LogicalExpression (I believe so) and we can do it in a single commit
Thanks!