-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break closing paren of ConditionalExpression in member chains #2786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks as always, you're rocking it this week 😃
What would it look like for logical expressions?
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
(valid | ||
? helper.responseBody(this.currentUser) | ||
: helper.responseBody(this.defaultUser)).prop; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand why it's happening, but this kinda feels like a regression on the changes in #2784. I think I'm okay with it, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, that's my mistake I forgot to update this test 😳
2d4fbd9
to
2ce3c0a
Compare
@suchipi I forgot to update a snapshot 😅 I updated it with what I think would work for logical expressions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍
Looks like CI is failing due to a format violation; could you fix? |
Oops so sorry about that. Fixed! |
Still related to #2775, maybe a better way to print this case.
If you guys think this is cool, let me know if I should do the same for LogicalExpression (I believe so) and we can do it in a single commit
Thanks!