Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add filenames to flow-verify test descriptions #2991

Merged
merged 1 commit into from Oct 8, 2017

Conversation

@chrisvoll
Copy link
Contributor

commented Oct 7, 2017

This PR makes jest's verbose test output more readable; now if one of the flow tests fails, the filename will be included in the test description. This change won't affect any snapshots since those are indexed using the filename.

Before:

$ jest method-chain
 PASS  tests/method-chain/jsfmt.spec.js
  ✓ flow - undefined-verify (4ms)
  ✓ bracket_0.js - typescript-verify (263ms)
  ✓ flow - undefined-verify (6ms)
  ✓ break-last-call.js - typescript-verify (27ms)
  ✓ flow - undefined-verify
  ✓ break-last-member.js - typescript-verify (7ms)
  ✓ flow - undefined-verify
  ✓ break-multiple.js - typescript-verify (2ms)
  ✓ flow - undefined-verify
  ✓ comment.js - typescript-verify (16ms)
  ✓ flow - undefined-verify
  ✓ computed-merge.js - typescript-verify (6ms)
  ✓ flow - undefined-verify
  ✓ computed.js - typescript-verify (3ms)
  ✓ flow - undefined-verify
  ✓ conditional.js - typescript-verify (6ms)
  ✓ flow - undefined-verify (1ms)
  ✓ first_long.js - typescript-verify (10ms)
  ✓ flow - undefined-verify (1ms)
  ✓ inline_merge.js - typescript-verify (1ms)
  ✓ flow - undefined-verify
  ✓ logical.js - typescript-verify (4ms)
  ✓ flow - undefined-verify (1ms)
  ✓ multiple-members.js - typescript-verify (4ms)
  ✓ flow - undefined-verify
  ✓ square_0.js - typescript-verify (1ms)
  ✓ flow - undefined-verify
  ✓ test.js - typescript-verify (2ms)
  ✓ flow - undefined-verify (1ms)
  ✓ this.js - typescript-verify (1ms)

After:

$ jest method-chain
 PASS  tests/method-chain/jsfmt.spec.js
  ✓ bracket_0.js - flow-verify (3ms)
  ✓ bracket_0.js - typescript-verify (255ms)
  ✓ break-last-call.js - flow-verify
  ✓ break-last-call.js - typescript-verify (27ms)
  ✓ break-last-member.js - flow-verify
  ✓ break-last-member.js - typescript-verify (9ms)
  ✓ break-multiple.js - flow-verify (1ms)
  ✓ break-multiple.js - typescript-verify (1ms)
  ✓ comment.js - flow-verify
  ✓ comment.js - typescript-verify (16ms)
  ✓ computed-merge.js - flow-verify
  ✓ computed-merge.js - typescript-verify (5ms)
  ✓ computed.js - flow-verify
  ✓ computed.js - typescript-verify (2ms)
  ✓ conditional.js - flow-verify
  ✓ conditional.js - typescript-verify (6ms)
  ✓ first_long.js - flow-verify
  ✓ first_long.js - typescript-verify (10ms)
  ✓ inline_merge.js - flow-verify
  ✓ inline_merge.js - typescript-verify (2ms)
  ✓ logical.js - flow-verify
  ✓ logical.js - typescript-verify (4ms)
  ✓ multiple-members.js - flow-verify
  ✓ multiple-members.js - typescript-verify (4ms)
  ✓ square_0.js - flow-verify
  ✓ square_0.js - typescript-verify (1ms)
  ✓ test.js - flow-verify
  ✓ test.js - typescript-verify (2ms)
  ✓ this.js - flow-verify
  ✓ this.js - typescript-verify (2ms)
@lydell lydell merged commit 67e4b7d into prettier:master Oct 8, 2017
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 6c8cde9...642209c
Details
codecov/project 97% remains the same compared to 6c8cde9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lydell

This comment has been minimized.

Copy link
Collaborator

commented Oct 8, 2017

Thanks!

@chrisvoll chrisvoll deleted the chrisvoll:cv-test-descriptions branch Oct 8, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.