New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): no extra whitespace between non-cjk and cjk-punctuation #3244

Merged
merged 2 commits into from Nov 11, 2017

Conversation

Projects
None yet
3 participants
@ikatyang
Member

ikatyang commented Nov 11, 2017

Fixes #3241

The root cause here is the regex mismatching, I thought RegExp#lastIndex only affected RegExp#exec(). 馃槶

@ikatyang ikatyang merged commit 1cde865 into prettier:master Nov 11, 2017

3 checks passed

codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 97.05% (+0%) compared to 9245904
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ikatyang ikatyang deleted the ikatyang:fix/markdown-cjk-punctuation-matching branch Nov 11, 2017

@suchipi suchipi added this to the 1.9 milestone Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment