New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve intentional new lines in GraphQL #3252

Merged
merged 5 commits into from Nov 12, 2017

Conversation

Projects
None yet
3 participants
@duailibe
Member

duailibe commented Nov 12, 2017

Fix #3251

duailibe added some commits Nov 12, 2017

@azz

azz approved these changes Nov 12, 2017

Nice! Could you add a test with comments on the fields as that's the primary use case.

@duailibe

This comment has been minimized.

Member

duailibe commented Nov 12, 2017

Will do!

I should also add support to newlines inside arguments, as the example in the issue also contains them

# comment
arg2: 10
) {

This comment has been minimized.

@azz

azz Nov 12, 2017

Member

This line looks odd to me

This comment has been minimized.

@duailibe

duailibe Nov 12, 2017

Member

This is the current behavior when it breaks: playground link

This comment has been minimized.

@azz

azz Nov 12, 2017

Member

Yeah. Don't have any better ideas either. Fine to leave it.

@azz

azz approved these changes Nov 12, 2017

@duailibe duailibe merged commit ece764a into prettier:master Nov 12, 2017

3 checks passed

codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 97.06% (+0.01%) compared to bddbd19
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@duailibe duailibe deleted the duailibe:gql-fields-newline branch Nov 12, 2017

@suchipi suchipi added this to the 1.9 milestone Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment