New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): only indent the first non-list node in checkbox list item #3297

Merged
merged 3 commits into from Nov 21, 2017

Conversation

Projects
None yet
2 participants
@ikatyang
Member

ikatyang commented Nov 20, 2017

Fixes #3295

@@ -5,9 +5,9 @@ exports[`checkbox.md 1`] = `
- [x] this is a long long long long long long long long long long long long long long paragraph.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* [ ] this is a long long long long long long long long long long long long long
long paragraph.
long paragraph.

This comment has been minimized.

@suchipi

suchipi Nov 20, 2017

Member

This is kinda undesirable; can we keep the alignment for non-checked list items?

ikatyang added some commits Nov 20, 2017

@ikatyang ikatyang changed the title from fix(markdown): do not indent checkbox to fix(markdown): only indent the first non-list node in checkbox list item Nov 21, 2017

@ikatyang ikatyang merged commit d5a3abd into prettier:master Nov 21, 2017

3 checks passed

codecov/patch 100% of diff hit (target 80%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +2.92% compared to b6f126e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ikatyang ikatyang deleted the ikatyang:fix/markdown-checkbox branch Nov 21, 2017

@suchipi suchipi added this to the 1.9 milestone Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment