Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Simple arrow function parens option #3324
This PR adds an "--arrow-function-parentheses" choice option with two options: "always" and "avoid". Avoid is the same as now (try not to print them if you can). Always is the new option (always print them). Avoid is the default, for backwards-compatibility.
Unlike #2676, this does not include the callbacks option AKA functional. Even though I find it interesting, I don't think there is community/collaborator buy-in or consensus, and I don't want to not add "always" because of that.
This PR also includes a fix that @rattrayalex started in his branch to inline type parameters on test callback functions (
Thanks for doing this. Disappointed to miss the
callbacks option this time around, of course, but I agree it's best to proceed with this for now.
We can wait and see if there's community demand and maybe merge in those changes later.
I don't think there's any lingering doubts about what you have here, so I think it's fine to merge.
I'll be happy to do so within a couple days if I don't hear concerns.