New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for flow mixins when using babylon #3391

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
4 participants
@bakkot
Collaborator

bakkot commented Dec 4, 2017

Partially fixes #3390.

Only works with babylon, since flow's parser doesn't seem to put the mixin into the AST (???).

@suchipi

suchipi approved these changes Dec 4, 2017

@suchipi

This comment has been minimized.

Member

suchipi commented Dec 4, 2017

@mroch do we need to do something differently to get mixins when using the flow parser?

@azz azz referenced this pull request Dec 4, 2017

Closed

Print flow mixins #3393

@azz

azz approved these changes Dec 4, 2017

@azz azz merged commit 8e377a1 into master Dec 4, 2017

5 checks passed

codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 97.07% (+<.01%) compared to 38b490b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@azz azz deleted the mixins branch Dec 4, 2017

@suchipi

This comment has been minimized.

Member

suchipi commented Dec 4, 2017

We should probably add a snapshot of multiple mixins like @azz's PR had

@bakkot bakkot referenced this pull request Apr 11, 2018

Closed

Upgrade Flow to 0.69 #4244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment