Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap awaits in unary expressions with parens #4315

Merged
merged 1 commit into from Apr 14, 2018

Conversation

@ZachGawlik
Copy link
Contributor

@ZachGawlik ZachGawlik commented Apr 14, 2018

Fixes #4138 by wrapping await expressions inside of unary expressions. (list of unary operators)

Sample input (currently prettier would leave this unchanged):

const w = !await resolveIdentity(false);
const x = -await resolveIdentity(3);
const y = +await resolveIdentity('3');
const z = typeof await resolveIdentity(false);

Output:

const w = !(await resolveIdentity(false));
const x = -(await resolveIdentity(3));
const y = +(await resolveIdentity('3'));
const z = typeof (await resolveIdentity(false));
@j-f1
j-f1 approved these changes Apr 14, 2018
Copy link
Member

@j-f1 j-f1 left a comment

Looks quite a bit clearer 👍

@lydell
lydell approved these changes Apr 14, 2018
Copy link
Member

@lydell lydell left a comment

I like this too!

@j-f1 j-f1 merged commit 0a22f5e into prettier:master Apr 14, 2018
4 checks passed
4 checks passed
@codecov
codecov/patch Coverage not affected when comparing 7c0dee6...6bd4745
Details
@codecov
codecov/project 95.82% remains the same compared to 7c0dee6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@j-f1
Copy link
Member

@j-f1 j-f1 commented Apr 14, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants