Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flow] Fix union indent inside of function param with a name #4325

Merged
merged 1 commit into from Apr 17, 2018

Conversation

@vjeux
Copy link
Collaborator

commented Apr 16, 2018

Fixes #4323

See #4323 for all the context.

I'd love to get it merged and ship a dot release if possible with it. It's affecting a bunch of code and prevents upgrading to the latest version of prettier at Facebook. I know it's been there for a while (since 1.9.3...)

@vjeux vjeux requested review from suchipi and duailibe Apr 16, 2018

append(
options?:
| string
| {

This comment has been minimized.

Copy link
@j-f1

j-f1 Apr 16, 2018

Member

Would this look better as options?: string | {?

This comment has been minimized.

Copy link
@vjeux

vjeux Apr 17, 2018

Author Collaborator

If I remember correctly, I only do the printing for undefined and null. We could extend it. I wanted to err on the safe side.

@vjeux vjeux merged commit 02a1db8 into prettier:master Apr 17, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 0a22f5e...be12c39
Details
codecov/project 95.82% remains the same compared to 0a22f5e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@vjeux

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 17, 2018

@suchipi: would you be able to cut 1.12.1 with this change by any chance? I really want to get the new release out to Facebook :p

@suchipi

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

@vjeux can do

@renovate renovate bot referenced this pull request Apr 17, 2018
0 of 1 task complete
@suchipi

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

@vjeux 1.12.1 is released

@zertosh

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

yay!

@vjeux

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 17, 2018

@suchipi thanks so much for the quick turnaround time!

@suchipi

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

You're welcome 😃

@lock lock bot locked as resolved and limited conversation to collaborators Jul 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.