Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split out JSON5 #4367

Merged
merged 5 commits into from Apr 25, 2018

Conversation

Projects
None yet
4 participants
@ikatyang
Copy link
Member

ikatyang commented Apr 24, 2018

Context: #4333 (comment)

This will allow:

  • insertPragma/requirePragma in JSON5
  • trailingComma in JSON5
  • consistent style for PropertyKey, we currently just print them as-is for JSON
@duailibe

This comment has been minimized.

Copy link
Member

duailibe commented Apr 24, 2018

Just need to fix integration tests snapshots

@azz

This comment has been minimized.

Copy link
Member

azz commented Apr 25, 2018

Tangentially relevant: webpack/webpack#6862 (review)

@azz

azz approved these changes Apr 25, 2018

@ikatyang ikatyang merged commit 317f3a3 into prettier:master Apr 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:feat/json5 branch Apr 25, 2018

@lipis lipis added this to the 1.13 milestone May 9, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.