Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(json): enforce StringLiteral-style property key #4371

Merged
merged 2 commits into from Apr 25, 2018

Conversation

Projects
None yet
4 participants
@ikatyang
Copy link
Member

ikatyang commented Apr 25, 2018

Fixes #4332

Since we splitted out the JSON5 parser (--parser json5), this change should be fine now.

@j-f1

j-f1 approved these changes Apr 25, 2018

@ikatyang ikatyang merged commit 289b98c into prettier:master Apr 25, 2018

4 checks passed

codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 95.81% (+<.01%) compared to 317f3a3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:feat/json-string-literal-key branch Apr 25, 2018

@lipis lipis added this to the 1.13 milestone May 9, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.