Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Flow's proto modifier syntax #4551

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
3 participants
@existentialism
Copy link
Collaborator

commented May 25, 2018

Flow commit: facebook/flow@eb815be

Babel PR: babel/babel#7978

@@ -0,0 +1 @@
run_spec(__dirname, ["flow"]);

This comment has been minimized.

Copy link
@suchipi

suchipi May 25, 2018

Member

Since this is supported by babel, too, should we run this with babylon as well?

This comment has been minimized.

Copy link
@existentialism

existentialism May 25, 2018

Author Collaborator

We actually just landed it, so I'll enable it after our next release!

This comment has been minimized.

Copy link
@suchipi

suchipi May 25, 2018

Member

Cool 👍

@existentialism existentialism merged commit fda7bf5 into master May 25, 2018

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

@existentialism existentialism deleted the flow-proto branch May 25, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.