Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): better handling for trailing spaces #4593

Merged
merged 1 commit into from Jun 7, 2018

Conversation

@ikatyang
Copy link
Member

commented May 29, 2018

  • preserve trailing spaces in html, excluding html comment
  • doc-printer is now unrelated to options.parser
  • fix some cases that two trailing spaces are mis-considered as break
@ikatyang

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2018

Does anyone want to take a look at this?

@j-f1 j-f1 requested review from duailibe and azz Jun 5, 2018

@duailibe

This comment has been minimized.

Copy link
Member

commented Jun 5, 2018

Sorry this went unnoticed

@ikatyang ikatyang merged commit 35a42be into prettier:master Jun 7, 2018

6 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/markdown-trailing-space branch Jun 7, 2018

bors bot added a commit to mozilla/delivery-console that referenced this pull request Jun 8, 2018
Merge #185
185: Update dependency prettier to v1.13.5 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.4` to `v1.13.5`



<details>
<summary>Release Notes</summary>

### [`v1.13.5`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1135)
[Compare Source](prettier/prettier@1.13.4...1.13.5)
[link](prettier/prettier@1.13.4...1.13.5)

- Better handling of trailing spaces in Markdown ([#&#8203;4593](`prettier/prettier#4593))
- Fix empty file error in JSON and GraphQL ([#&#8203;4553](`prettier/prettier#4553))
- Preserve decorator on TypeScript interfaces ([#&#8203;4632](`prettier/prettier#4632))
- Inline \_ or $ in the root of a method chain ([#&#8203;4621](`prettier/prettier#4621))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
peterbe added a commit to mozilla-services/tecken that referenced this pull request Jun 22, 2018
Update dependency prettier to v1.13.5 (#906)
This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.4` to `v1.13.5`



<details>
<summary>Release Notes</summary>

### [`v1.13.5`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1135)
[Compare Source](prettier/prettier@1.13.4...1.13.5)
[diff](prettier/prettier@1.13.4...1.13.5)

- Better handling of trailing spaces in Markdown ([#&#8203;4593](`prettier/prettier#4593))
- Fix empty file error in JSON and GraphQL ([#&#8203;4553](`prettier/prettier#4553))
- Preserve decorator on TypeScript interfaces ([#&#8203;4632](`prettier/prettier#4632))
- Inline \_ or $ in the root of a method chain ([#&#8203;4621](`prettier/prettier#4621))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

@lock lock bot locked as resolved and limited conversation to collaborators Sep 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.