Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): regression for --debug-check + --list-different #4600

Merged

Conversation

@ikatyang
Copy link
Member

commented May 30, 2018

Fixes #4599

The regression was introduced in #4528, output is actually not prettified code under --debug-check, e.g. the check output !== input is actually "index.js" !== "console.log("…");" in #4599.

The returned value from format() is really confusing, we should refactor it.

@j-f1 j-f1 changed the title fix(cli): no regression for --debug-check + --list-different fix(cli): regression for --debug-check + --list-different May 30, 2018

@ikatyang ikatyang merged commit 75e86b9 into prettier:master May 30, 2018

6 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/cli-debug-check-with-list-different branch May 30, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.