Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): regression for `hasOwnProperty` #4603

Merged

Conversation

@ikatyang
Copy link
Member

commented May 30, 2018

Fixes #4602

"flow", // Lodash
"flowRight", // Lodash
"connect" // Redux
];

This comment has been minimized.

Copy link
@duailibe

duailibe May 30, 2018

Member

We used an object here specifically to prevent calling indexOf. I suggest we use Object.create(null), Map or a Set

@j-f1
j-f1 approved these changes May 30, 2018

@j-f1 j-f1 changed the title fix(javascript): no regression for `hasOwnProperty` fix(javascript): regression for `hasOwnProperty` May 30, 2018

@IvanGoncharov

This comment has been minimized.

Copy link

commented May 30, 2018

@ikatyang Thanks for the super fast fix 🏁🏎👏
I'm just wondering when to expect next release with this fix included?

@lydell
lydell approved these changes May 30, 2018
flowRight: true, // Lodash
connect: true // Redux
};
const functionCompositionFunctionNames = new Set([

This comment has been minimized.

Copy link
@lydell

lydell May 30, 2018

Collaborator

Hehe, I proposed using a Set in the original PR :)

#4431 (comment)

@ikatyang ikatyang merged commit 8abbc5d into prettier:master May 30, 2018

6 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/javascript-no-regression-hasOwnProperty branch May 30, 2018

@ikatyang

This comment has been minimized.

Copy link
Member Author

commented May 30, 2018

I'm not sure when but we should make these regression fixes available as soon as possible.

And it seems Jest also encountered this issue facebook/jest#6344 (comment).

@duailibe what do you think?

@duailibe

This comment has been minimized.

Copy link
Member

commented May 30, 2018

@ikatyang makes sense. I'll release 1.13.3

bors bot added a commit to mozilla/delivery-console that referenced this pull request May 30, 2018
Merge #172
172: Update dependency prettier to v1.13.3 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.2` to `v1.13.3`



<details>
<summary>Release Notes</summary>

### [`v1.13.3`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1133)
[Compare Source](prettier/prettier@1.13.2...75e86b9)
[link](prettier/prettier@1.13.2...1.13.3)

- Fix a regression when printing `hasOwnProperty` and other functions in `Object`'s prototype ([#&#8203;4603](`prettier/prettier#4603))
- Fix a regression in exit status when using `--debug-check` and `--list-different` ([#&#8203;4600](https://github.com/prettier/prettier/pul/4600))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>

@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.