Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline _ or $ in the root of a method chain #4621

Merged
merged 2 commits into from Jun 1, 2018

Conversation

@duailibe
Copy link
Member

commented Jun 1, 2018

Closes #4614

function isFactory(name) {
return /^[A-Z]/.test(name);
return /^[A-Z]|^[_$]+$/.test(name);

This comment has been minimized.

Copy link
@evilebottnawi

evilebottnawi Jun 1, 2018

Member

Can we add test with $ to avoid regression in future?

@j-f1
j-f1 approved these changes Jun 1, 2018
@suchipi
suchipi approved these changes Jun 1, 2018

@duailibe duailibe merged commit a4da6e6 into prettier:master Jun 1, 2018

6 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details

@duailibe duailibe deleted the duailibe:factories branch Jun 1, 2018

@duailibe

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2018

@suchipi @evilebottnawi @j-f1 Do you think we should release Prettier 1.13.5 ?

@suchipi

This comment has been minimized.

Copy link
Member

commented Jun 1, 2018

Let's wait a day or two and see if anything else comes up

bors bot added a commit to mozilla/delivery-console that referenced this pull request Jun 8, 2018
Merge #185
185: Update dependency prettier to v1.13.5 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.4` to `v1.13.5`



<details>
<summary>Release Notes</summary>

### [`v1.13.5`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1135)
[Compare Source](prettier/prettier@1.13.4...1.13.5)
[link](prettier/prettier@1.13.4...1.13.5)

- Better handling of trailing spaces in Markdown ([#&#8203;4593](`prettier/prettier#4593))
- Fix empty file error in JSON and GraphQL ([#&#8203;4553](`prettier/prettier#4553))
- Preserve decorator on TypeScript interfaces ([#&#8203;4632](`prettier/prettier#4632))
- Inline \_ or $ in the root of a method chain ([#&#8203;4621](`prettier/prettier#4621))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
peterbe added a commit to mozilla-services/tecken that referenced this pull request Jun 22, 2018
Update dependency prettier to v1.13.5 (#906)
This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.4` to `v1.13.5`



<details>
<summary>Release Notes</summary>

### [`v1.13.5`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1135)
[Compare Source](prettier/prettier@1.13.4...1.13.5)
[diff](prettier/prettier@1.13.4...1.13.5)

- Better handling of trailing spaces in Markdown ([#&#8203;4593](`prettier/prettier#4593))
- Fix empty file error in JSON and GraphQL ([#&#8203;4553](`prettier/prettier#4553))
- Preserve decorator on TypeScript interfaces ([#&#8203;4632](`prettier/prettier#4632))
- Inline \_ or $ in the root of a method chain ([#&#8203;4621](`prettier/prettier#4621))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

@lock lock bot locked as resolved and limited conversation to collaborators Aug 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.