Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): preserve parens for type casting for sub-item #4648

Conversation

@ikatyang
Copy link
Member

commented Jun 7, 2018

Fixes #4287

@suchipi
suchipi approved these changes Jun 7, 2018
@@ -5,19 +5,39 @@ const assert = require("assert");
const util = require("../common/util");
const comments = require("./comments");

function hasClosureCompilerTypeCastComment(text, node, locEnd) {
function hasClosureCompilerTypeCastComment(text, path, locStart, locEnd) {

This comment has been minimized.

Copy link
@j-f1

j-f1 Jun 7, 2018

Member

How do you feel about dropping ClosureCompiler from this name since it supports TS too?

This comment has been minimized.

Copy link
@ikatyang

ikatyang Jun 7, 2018

Author Member

Actually, that syntax seems coming from closure compiler, see microsoft/TypeScript#5158.

This comment was marked as off-topic.

Copy link
@m1ck2

m1ck2 Jun 7, 2018

Hi is this the correct place to comment.

This comment was marked as off-topic.

Copy link
@m1ck2

m1ck2 Jun 7, 2018

Hi is this the correct place to comment.

This comment has been minimized.

Copy link
@thorn0

thorn0 Jun 8, 2018

Contributor

Salsa ≠ TypeScript (the language)

This comment has been minimized.

Copy link
@j-f1

j-f1 Jun 8, 2018

Member

What’s Salsa then?

This comment has been minimized.

Copy link
@j-f1
@m1ck2

This comment was marked as off-topic.

Copy link

commented Jun 7, 2018

@ikatyang
I was trying to respond earlier but all of a sudden all my network services droped out.

@ikatyang ikatyang merged commit 5646573 into prettier:master Jun 11, 2018

6 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/javascript-parens-for-type-cast-for-sub-item branch Jun 11, 2018

bors bot added a commit to mozilla/delivery-console that referenced this pull request Jun 25, 2018
Merge #241
241: Update dependency prettier to v1.13.6 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.5` to `v1.13.6`



<details>
<summary>Release Notes</summary>

### [`v1.13.6`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1136)
[Compare Source](prettier/prettier@1.13.5...1.13.6)
[diff](prettier/prettier@1.13.5...1.13.6)

- Upgrade Flow parser to 0.75.0 ([#&#8203;4649](`prettier/prettier#4649) and [#&#8203;4727](`prettier/prettier#4727))
- Preserve type parameters of import-types in TypeScript ([#&#8203;4662](`prettier/prettier#4662))
- Preserve parens for type casting for sub-item ([#&#8203;4648](`prettier/prettier#4648))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
schalkneethling added a commit to mdn/interactive-examples that referenced this pull request Jun 27, 2018
chore(deps): update dependency prettier to v1.13.6 (#992)
This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.5` to `v1.13.6`



<details>
<summary>Release Notes</summary>

### [`v1.13.6`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1136)
[Compare Source](prettier/prettier@1.13.5...1.13.6)
[diff](prettier/prettier@1.13.5...1.13.6)

- Upgrade Flow parser to 0.75.0 ([#&#8203;4649](`prettier/prettier#4649) and [#&#8203;4727](`prettier/prettier#4727))
- Preserve type parameters of import-types in TypeScript ([#&#8203;4662](`prettier/prettier#4662))
- Preserve parens for type casting for sub-item ([#&#8203;4648](`prettier/prettier#4648))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

@lock lock bot locked as resolved and limited conversation to collaborators Sep 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants
You can’t perform that action at this time.