Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): support pragma #4713

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
3 participants
@ikatyang
Copy link
Member

ikatyang commented Jun 18, 2018

Fixes #4683

@j-f1
Copy link
Member

j-f1 left a comment

Can you add a test with requirePragma enabled but no pragma present in the source file?


`;

exports[`without-pragma.vue 1`] = `

This comment has been minimized.

Copy link
@ikatyang
@j-f1

j-f1 approved these changes Jun 18, 2018

Copy link
Member

j-f1 left a comment

Whoops, I missed that 😬

LGTM

@ikatyang ikatyang merged commit f51acf2 into prettier:master Jun 25, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.55% (+0.08%) compared to b99de98
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:feat/vue-support-pragma branch Jun 25, 2018

@ikatyang ikatyang added this to the 1.14 milestone Jul 17, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.