Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flow-parser to 0.75.0 #4727

Merged
merged 2 commits into from Jun 21, 2018

Conversation

@rubennorte
Copy link
Contributor

commented Jun 21, 2018

The main change in the parser is the support for optional catch bindings (which were a syntax error previously).

@existentialism

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2018

@rubennorte rubennorte force-pushed the rubennorte:upgrade-flow-parser branch from c742d4a to 6b30a5b Jun 21, 2018

@vjeux vjeux requested review from existentialism and duailibe Jun 21, 2018

@vjeux

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2018

@suchipi: would there be a way to release a dot release with just this change, so that we can start using it at Facebook? :)

@vjeux vjeux merged commit cbef010 into prettier:master Jun 21, 2018

8 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@duailibe

This comment has been minimized.

Copy link
Member

commented Jun 21, 2018

@vjeux we haven't done any releases off a branch (instead of master), but sure we can do that

@vjeux

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2018

I've done some in the early days in order to move fast :p

@rubennorte rubennorte deleted the rubennorte:upgrade-flow-parser branch Jun 21, 2018

@duailibe

This comment has been minimized.

Copy link
Member

commented Jun 21, 2018

I'll do it later tonight (UTC-3 here) if no one does before :) the release script doesn't support it though

@vjeux

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2018

Awesome, thanks a ton!

@rubennorte

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2018

@duailibe is there something we can do to help with this release?

@duailibe

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

@rubennorte Sorry I got distracted over the weekend, will release it right now

duailibe added a commit that referenced this pull request Jun 25, 2018
Upgrade flow-parser to 0.75.0 (#4727)
* Upgrade flow-parser to 0.75.0

* Added failing test for optional catch binding and flow-parser@0.74.0
@duailibe

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

@rubennorte @vjeux Just released 1.13.6.. Sorry it took a while!

@rubennorte

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2018

@duailibe no problem at all. Thank you very much!

bors bot added a commit to mozilla/delivery-console that referenced this pull request Jun 25, 2018
Merge #241
241: Update dependency prettier to v1.13.6 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.5` to `v1.13.6`



<details>
<summary>Release Notes</summary>

### [`v1.13.6`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1136)
[Compare Source](prettier/prettier@1.13.5...1.13.6)
[diff](prettier/prettier@1.13.5...1.13.6)

- Upgrade Flow parser to 0.75.0 ([#&#8203;4649](`prettier/prettier#4649) and [#&#8203;4727](`prettier/prettier#4727))
- Preserve type parameters of import-types in TypeScript ([#&#8203;4662](`prettier/prettier#4662))
- Preserve parens for type casting for sub-item ([#&#8203;4648](`prettier/prettier#4648))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
schalkneethling added a commit to mdn/interactive-examples that referenced this pull request Jun 27, 2018
chore(deps): update dependency prettier to v1.13.6 (#992)
This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.5` to `v1.13.6`



<details>
<summary>Release Notes</summary>

### [`v1.13.6`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1136)
[Compare Source](prettier/prettier@1.13.5...1.13.6)
[diff](prettier/prettier@1.13.5...1.13.6)

- Upgrade Flow parser to 0.75.0 ([#&#8203;4649](`prettier/prettier#4649) and [#&#8203;4727](`prettier/prettier#4727))
- Preserve type parameters of import-types in TypeScript ([#&#8203;4662](`prettier/prettier#4662))
- Preserve parens for type casting for sub-item ([#&#8203;4648](`prettier/prettier#4648))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

@lock lock bot locked as resolved and limited conversation to collaborators Sep 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.