Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom require's #4766

Merged
merged 1 commit into from Jun 28, 2018

Conversation

@duailibe
Copy link
Member

commented Jun 28, 2018

Regression in the build script left some eval("require") in the codebase.

I decided to remove the $$$r thing

@duailibe duailibe force-pushed the duailibe:fix-eval-require branch from 82d3b85 to b3ada4c Jun 28, 2018

@duailibe duailibe merged commit 576e570 into prettier:master Jun 28, 2018

9 of 10 checks passed

codecov/project 96.6% (-0.01%) compared to 0b659b8
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 88.23% of diff hit (target 80%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@duailibe duailibe deleted the duailibe:fix-eval-require branch Jun 28, 2018

duailibe added a commit that referenced this pull request Jun 28, 2018
schalkneethling added a commit to mdn/interactive-examples that referenced this pull request Jul 2, 2018
chore(deps): update dependency prettier to v1.13.7 (#1006)
This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.6` to `v1.13.7`



<details>
<summary>Release Notes</summary>

### [`v1.13.7`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1137)
[Compare Source](prettier/prettier@1.13.6...1.13.7)
[diff](prettier/prettier@1.13.6...1.13.7)

- Remove calls to `eval("require")` in the distributed code ([#&#8203;4766](`prettier/prettier#4766))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
rdela added a commit to rdela/rdela.com that referenced this pull request Jul 12, 2018
chore(deps): update dependency prettier to v1.13.7 (#45)
This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.6` to `v1.13.7`



<details>
<summary>Release Notes</summary>

### [`v1.13.7`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1137)
[Compare Source](prettier/prettier@1.13.6...1.13.7)
[diff](prettier/prettier@1.13.6...1.13.7)

- Remove calls to `eval("require")` in the distributed code ([#&#8203;4766](`prettier/prettier#4766))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.