Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print ObjectTypeInternalSlot with both flow/babel parsers #4869

Merged
merged 4 commits into from Aug 8, 2018

Conversation

@existentialism
Copy link
Collaborator

commented Jul 21, 2018

Fixes #4903

Now that facebook/flow#6320 has landed, we can add support for ObjectTypeInternalSlot!

WIP while waiting for flow-parser@0.77 to hit npm (it's tagged).

Ref:
facebook/flow@732eae5
babel/babel#7947
babel/babel#7959

return concat([
n.static ? "static " : "",
"[[",
path.call(print, "id"),

This comment has been minimized.

Copy link
@j-f1

j-f1 Jul 21, 2018

Member

What happens if the identifier goes past the printWidth?

@ikatyang

This comment has been minimized.

Copy link
Member

commented Jul 28, 2018

Opened facebook/flow#6652 to ask for the flow-parser@0.77 release.

@dashed

This comment has been minimized.

Copy link

commented Aug 4, 2018

@ikatyang flow-parser@v0.78.0 is now published. Could that be used instead?

@ikatyang ikatyang added this to the 1.14.1 milestone Aug 7, 2018

@suchipi suchipi merged commit 1391891 into master Aug 8, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.47% (+<.01%) compared to a3ab95a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@existentialism existentialism deleted the flow77 branch Aug 8, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.