Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump babel-parser #4910

Merged
merged 6 commits into from Aug 3, 2018

Conversation

@existentialism
Copy link
Collaborator

commented Jul 30, 2018

Fixes #4876.

h/t @bakkot!

existentialism and others added 2 commits Jul 30, 2018
@existentialism

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 30, 2018

@ikatyang thanks :)

@ikatyang

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

The node 4 build failed. 🤔

@ikatyang

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

It seems it's caused by @babel/code-frame, see 84a16d7.

@existentialism

This comment has been minimized.

@existentialism

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 30, 2018

@ikatyang Nice, I was just looking at that 👍

@j-f1

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

Would it make sense to just bundle a polyfill for Array#includes so we don’t have to try to transform it?

@ikatyang

This comment has been minimized.

Copy link
Member

commented Jul 31, 2018

I think transformation should be enough for now unless there're edge cases that we can't fix it easily.

@existentialism existentialism merged commit 1597578 into prettier:master Aug 3, 2018

9 of 10 checks passed

codecov/project 96.46% (-0.02%) compared to 1915cc3
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1915cc3...9e2328e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@existentialism existentialism deleted the existentialism:babel-55 branch Aug 3, 2018

@ikatyang ikatyang added this to the 1.14.1 milestone Aug 3, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.