Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml): end comment in nested mapping #4918

Merged

Conversation

@ikatyang
Copy link
Member

commented Jul 31, 2018

Fixes #4917

A:
B:
#A
#A

This comment has been minimized.

Copy link
@j-f1

j-f1 Jul 31, 2018

Member

Didn’t these have to be at the end of the file to reproduce the bug?

This comment has been minimized.

Copy link
@ikatyang

ikatyang Jul 31, 2018

Author Member

It just needs to be at the end of a collection.

@ikatyang ikatyang merged commit b6077e1 into prettier:master Aug 2, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 10df246...c416376
Details
codecov/project 96.48% remains the same compared to 10df246
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/yaml-end-comment-in-nested-mapping branch Aug 2, 2018

@ikatyang ikatyang added this to the 1.14.1 milestone Aug 2, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.