Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert this/super blacklist for function composition heuristic #4936

Merged

Conversation

@suchipi
Copy link
Member

commented Aug 3, 2018

Fixes #4925

sortBy(x => x),
flatten,
sortBy(x => x),
flatten,

This comment has been minimized.

Copy link
@suchipi

suchipi Aug 3, 2018

Author Member

Sorry, my editor did this

@ikatyang ikatyang added this to the 1.14.1 milestone Aug 3, 2018

@j-f1

This comment has been minimized.

Copy link
Member

commented Aug 3, 2018

How about keeping the blacklist for this.compose/super.compose, but still printing more complicated calls in the FP style?

@suchipi

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2018

Would we keep this.pipe?

@j-f1

This comment has been minimized.

Copy link
Member

commented Aug 3, 2018

I’d say we should have the same behavior for pipe as for compose.

@suchipi

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2018

I think it's really important for RxJS users that pipe has FP style formatting.
Maybe we don't need it for compose unless it's being used in the curried call format that redux does. But I'm hesitant to change it.

@suchipi

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2018

Good to merge?

@suchipi suchipi merged commit 418a04b into prettier:master Aug 8, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.52% compared to a3ab95a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.