Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update flow support info #4943

Merged
merged 2 commits into from Aug 8, 2018

Conversation

@ikatyang
Copy link
Member

commented Aug 7, 2018

Fixes #4942

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@ikatyang ikatyang added this to the 1.14.1 milestone Aug 7, 2018

@j-f1

This comment has been minimized.

Copy link
Member

commented Aug 7, 2018

Are there Flow versions of the JS-specific keys that are now added?

@ikatyang

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2018

I'm not sure what did you mean but the JavaScript in Linguist is actually js + flow, they didn't distinguish them. The reason why I originally added Flow is that I'd like to distinguish them, at least .js.flow is 100% Flow file.

@suchipi
suchipi approved these changes Aug 8, 2018

@ikatyang ikatyang merged commit e72cb53 into prettier:master Aug 8, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 308863e...1c5661b
Details
codecov/project 96.47% remains the same compared to 308863e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/flow/support-info branch Aug 8, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.