Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): use the first error when both failed #4947

Merged

Conversation

@ikatyang
Copy link
Member

commented Aug 8, 2018

Fixes #4946

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
@duailibe

This comment has been minimized.

Copy link
Member

commented Aug 8, 2018

@ikatyang Do you know what's the problem of always using "with JSX" mode?

@j-f1

This comment has been minimized.

Copy link
Member

commented Aug 8, 2018

You can’t use type parameters with arrow functions:

const foo = <T>(x: T): T => x
@duailibe

This comment has been minimized.

Copy link
Member

commented Aug 8, 2018

🤦‍♂️

@j-f1
j-f1 approved these changes Aug 8, 2018

@ikatyang ikatyang added this to the 1.14.2 milestone Aug 9, 2018

@ikatyang ikatyang merged commit 3842cbb into prettier:master Aug 9, 2018

9 of 10 checks passed

codecov/project 96.46% (-0.02%) compared to 308863e
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 80% of diff hit (target 80%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/typescript/first-error-when-both-failed branch Aug 9, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.