Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4963: parens are incorrectly stripped in BindExpression #4964

Merged
merged 5 commits into from Aug 9, 2018

Conversation

Projects
None yet
5 participants
@TitanSnow
Copy link
Contributor

commented Aug 9, 2018

Fixes #4963

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

TitanSnow added some commits Aug 9, 2018

@TitanSnow TitanSnow closed this Aug 9, 2018

@j-f1

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

Why did this get closed @TitanSnow?

@TitanSnow TitanSnow reopened this Aug 9, 2018

@TitanSnow

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

@j-f1 Because I was going to add more commits

@TitanSnow TitanSnow changed the title fix #4963: parens are incorrectly stripped for MemberExpression and CallExpression in BindExpression fix #4963: parens are incorrectly stripped in BindExpression Aug 9, 2018

@suchipi

suchipi approved these changes Aug 9, 2018

@duailibe duailibe merged commit b0a33b7 into prettier:master Aug 9, 2018

9 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.48% (+<.01%) compared to 26fd292
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@duailibe

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

Thanks!

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.