New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yaml): prefer implicit key for empty value #4972

Merged
merged 3 commits into from Aug 12, 2018

Conversation

Projects
None yet
3 participants
@ikatyang
Member

ikatyang commented Aug 11, 2018

Fixes #4971

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@ikatyang ikatyang added status:wip and removed status:wip labels Aug 11, 2018

? Ken Griffey
Mark McGwire:
Sammy Sosa:
Ken Griffey:

This comment has been minimized.

@j-f1

j-f1 Aug 11, 2018

Member

IMO we should keep the ? syntax in this case (!!set) since these keys can’t have values and they can be any type of object.

ikatyang added some commits Aug 11, 2018

@j-f1

j-f1 approved these changes Aug 11, 2018

@j-f1

j-f1 approved these changes Aug 11, 2018

@ikatyang ikatyang merged commit 6ba6138 into prettier:master Aug 12, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b0a33b7...35f6948
Details
codecov/project 96.48% remains the same compared to b0a33b7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:feat/yaml-prefer-implicit-key-for-empty-value branch Aug 12, 2018

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment