New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify the precedingNode type when handling import declaration comments #5016

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
4 participants
@ericsakmar
Contributor

ericsakmar commented Aug 24, 2018

Fixes #4847 by making sure that the precedingNode is of type ImportSpecifier.

In the example mentioned in the original issue, where the comment should not be moved outside the block, precedingNode.type is ImportDefaultSpecifier.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
@j-f1

j-f1 approved these changes Aug 24, 2018

@suchipi

Thank you!

@suchipi suchipi merged commit 93e8b15 into prettier:master Aug 28, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 58d34bb...6360b7f
Details
codecov/project 96.48% remains the same compared to 58d34bb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment