New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ Leave Dangle Comments in NewExpression #5017

Merged
merged 4 commits into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@flxwu
Contributor

flxwu commented Aug 25, 2018

Resolves #4953

new Thing(/* comment */)

now stays the same instead of being formatted into

new Thing /* comment */()
  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
const lineBeforeOperator = node.operator === "|>";
const lineBeforeOperator =
node.operator === "|>" &&
!hasLeadingOwnLineComment(options.originalText, node.right, options);

This comment has been minimized.

@ikatyang

ikatyang Aug 25, 2018

Member

It seems you accidentally include commits from #5015.

This comment has been minimized.

@flxwu

flxwu Aug 26, 2018

Contributor

yep, you're right. Thanks for noticing! 😅

@j-f1

j-f1 approved these changes Aug 25, 2018

LGTM except what @ikatyang pointed out.

@flxwu

This comment has been minimized.

Contributor

flxwu commented Aug 26, 2018

fixed Review comments :)

@j-f1

j-f1 approved these changes Aug 26, 2018

@ikatyang ikatyang merged commit 8779937 into prettier:master Aug 27, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 58d34bb...bba2539
Details
codecov/project 96.48% remains the same compared to 58d34bb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@ikatyang

This comment has been minimized.

Member

ikatyang commented Aug 27, 2018

Thanks!

@flxwu flxwu deleted the flxwu:bugfix/dangle-comments-newExpression branch Aug 27, 2018

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment